Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async ccc checker #971

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Aug 9, 2024

1. Purpose or design rationale of this PR

implements an async CCC checker that maintains a backlog of blocks to be CCC checked. On success, it writes the calculated RowConsumption to the database. On failure it invokes the user callback to handle the failure.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak force-pushed the omerfirmak/async-ccc branch from a5ee780 to 7e4b11f Compare August 12, 2024 06:17
@omerfirmak omerfirmak force-pushed the omerfirmak/async-ccc branch from 7e4b11f to 2efb3c2 Compare August 12, 2024 10:07
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Recommend keeping this on a feature branch until more thorough testing.

@omerfirmak omerfirmak changed the base branch from develop to feat/lightweight-ccc August 13, 2024 12:19
@omerfirmak omerfirmak merged commit 7f9564e into feat/lightweight-ccc Aug 13, 2024
7 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/async-ccc branch August 13, 2024 13:24
omerfirmak added a commit that referenced this pull request Aug 21, 2024
omerfirmak added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants